Skip to content

fix(textInput): Value must be at least 1 character in length #10805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix(textInput): Value must be at least 1 character in length #10805

merged 1 commit into from
Mar 17, 2025

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Will throw this error otherwise: data.components[1].components[0].value[BASE_TYPE_MIN_LENGTH]: Must be 1 or more in length.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite requested a review from a team as a code owner March 17, 2025 14:48
@Jiralite Jiralite requested a review from didinele March 17, 2025 14:48
@vercel Vercel
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Mar 17, 2025 2:48pm
discord-js-guide ⬜️ Ignored (Inspect) Mar 17, 2025 2:48pm

@Jiralite Jiralite added this to the builders 2.0.0 milestone Mar 17, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.66%. Comparing base (a151424) to head (f5fb1f9).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10805   +/-   ##
=======================================
  Coverage   39.66%   39.66%           
=======================================
  Files         249      249           
  Lines       15206    15206           
  Branches     1456     1456           
=======================================
  Hits         6031     6031           
  Misses       9163     9163           
  Partials       12       12
Flag Coverage Δ
builders 76.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Mar 17, 2025
@kodiakhq kodiakhq bot merged commit 4d19426 into main Mar 17, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Mar 17, 2025
@kodiakhq kodiakhq bot deleted the fix/text-value-length branch March 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@sdanialraza sdanialraza sdanialraza approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/builders

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/builders

Assignees
No one assigned
Labels
packages:builders semver:patch
Projects
discord.js
Archived in project
Milestone
builders 2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiralite @vladfrangu @didinele @sdanialraza